ReleaseKit Updated #148
ReleaseKit Updated #148
Conversation
Satya-egov
requested review from
sathishp-eGov
and removed request for
a team
WalkthroughThis pull request updates localization and schema files for the HCM Admin Console and Campaign Manager. In the localization files, it removes legacy campaign delivery messages (LLIN/MILDA) from the admin schemas and adds corresponding entries in the campaign manager files for English, French, and Portuguese locales. Additionally, in the MDMS files, the schema for campaign boundaries is enhanced with new target-related properties and stricter validation rules, and the campaign identifier is standardized by replacing "LLIN-mz" with "LLIN". Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
localisation/HCM Admin Console/v0.3.1 patch/pt_MZ/hcm-campaignmanager.json (1)
32-37:⚠️ Potential issueLocale Inconsistency Detected
The entry for"FACILITY_MAPPING_POP_HEADER_TITLE"shows"locale": "pt_IN"instead of the expected"pt_MZ". Please correct this to ensure that the localization file is consistent with the Mozambique locale.
🧹 Nitpick comments (3)
localisation/HCM Admin Console/v0.3.1 patch/en_MZ/hcm-admin-schemas.json (1)
15-20: Fix Typographical Error in Household Target MessageIn the "HCM_ADMIN_CONSOLE_TARGET_HOUSEHOLD" object, the message reads "Household Targe" instead of the intended "Household Target." Please correct the typo to maintain consistency and clarity in the UI messaging.
A suggested diff is provided below:
- "message": "Household Targe", + "message": "Household Target",localisation/HCM Admin Console/v0.3.1 patch/fr_MZ/hcm-campaignmanager.json (2)
2-7: New Localization Entry Added for fr_MZ
A new entry for"CAMPAIGN_DELIVERY_TAB_SUB_TEXT_LLIN"is added with the message"Configurer les conditions de livraison pour la campagne MILDA". Note that the French entry uses “MILDA” rather than “LLIN” (as in the en_MZ and pt_MZ files). Please verify that this difference is intentional and aligns with your campaign nomenclature for the French locale.
645-661: Review Campaign Naming Consistency in French
Within the French localization file, there’s an apparent discrepancy in naming. For example, the keys:
"CAMPAIGN_CYCLE_CONFIGURE_HEADING_LLIN"and"CAMPAIGN_PROJECT_LLIN"
have messages set to"Configuration pour la campagne MILDA", while the entry for code"LLIN"uses the message"Configurer les MILD ".
Please review these entries for consistency (and correct any typos such as “MILD” vs. “MILDA”) so that the campaign names are uniform across French translations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
localisation/HCM Admin Console/v0.3.1 patch/en_MZ/hcm-admin-schemas.json(1 hunks)localisation/HCM Admin Console/v0.3.1 patch/en_MZ/hcm-campaignmanager.json(1 hunks)localisation/HCM Admin Console/v0.3.1 patch/fr_MZ/hcm-admin-schemas.json(1 hunks)localisation/HCM Admin Console/v0.3.1 patch/fr_MZ/hcm-campaignmanager.json(1 hunks)localisation/HCM Admin Console/v0.3.1 patch/pt_MZ/hcm-admin-schemas.json(0 hunks)localisation/HCM Admin Console/v0.3.1 patch/pt_MZ/hcm-campaignmanager.json(1 hunks)mdms/HCM/HCM ADMINCONSOLE v0.3.1 patch/JSON DATAS/HCM Admin Console/adminSchema.json(2 hunks)mdms/HCM/HCM ADMINCONSOLE v0.3.1 patch/JSON DATAS/HCM Admin Console/allAttributes.json(1 hunks)mdms/HCM/HCM ADMINCONSOLE v0.3.1 patch/JSON DATAS/HCM Admin Console/projectTypesLLIN.json(1 hunks)mdms/HCM/HCM ADMINCONSOLE v0.3.1 patch/JSON DATAS/HCM Admin Console/targetConfigs.json(1 hunks)
💤 Files with no reviewable changes (1)
- localisation/HCM Admin Console/v0.3.1 patch/pt_MZ/hcm-admin-schemas.json
🔇 Additional comments (11)
mdms/HCM/HCM ADMINCONSOLE v0.3.1 patch/JSON DATAS/HCM Admin Console/allAttributes.json (1)
60-60: Standardize Project Type Value for MemberCountThe value in the "projectTypes" array for the memberCount attribute has been updated from the legacy "LLIN-mz" to the new standardized "LLIN". This change aligns with the overall effort to simplify campaign type identifiers. Please verify that any downstream logic consuming this attribute is updated accordingly.
mdms/HCM/HCM ADMINCONSOLE v0.3.1 patch/JSON DATAS/HCM Admin Console/targetConfigs.json (1)
20-20: Update Campaign Type IdentifierThe "campaignType" value has been updated from "LLIN-mz" to "LLIN", ensuring consistency across MDMS configurations. Confirm that front-end and API consumers of this configuration recognize the updated identifier without issues.
mdms/HCM/HCM ADMINCONSOLE v0.3.1 patch/JSON DATAS/HCM Admin Console/projectTypesLLIN.json (1)
3-3: Standardize Project Type CodeThe "code" field has been changed from the legacy "LLIN-mz" to the simplified "LLIN" for the LLIN campaign type configuration. This update supports the overall standardization effort.
localisation/HCM Admin Console/v0.3.1 patch/en_MZ/hcm-admin-schemas.json (1)
2-8: Add New Target Message EntriesA set of new JSON objects has been added to enhance target-related messaging for the HCM Admin Console. These entries provide improved clarity on target populations and configurations. The changes appear well structured and consistent with the standardization effort.
localisation/HCM Admin Console/v0.3.1 patch/fr_MZ/hcm-admin-schemas.json (1)
1-8: Remove Legacy Campaign Delivery MessageThe legacy JSON object associated with the MILDA (LLIN) campaign delivery message has been successfully removed. The update removes outdated messaging from the French localization schema and aligns with the changes made in other locale files.
mdms/HCM/HCM ADMINCONSOLE v0.3.1 patch/JSON DATAS/HCM Admin Console/adminSchema.json (4)
177-222: New MR-DN Target Properties Added
New numeric properties for the “MR-DN” campaign (e.g.HCM_ADMIN_CONSOLE_TARGET_SMC_AGE_3_TO_11,HCM_ADMIN_CONSOLE_TARGET_SMC_AGE_12_TO_59, etc.) have been introduced. Please verify that their required status and validation constraints match the business rules for MR-DN campaigns and that downstream validations/data providers are updated accordingly.
320-320: Update Campaign Type for LLIN Boundary
The"campaignType"for the boundary object has been updated from the legacy value (likely"LLIN-mz") to"LLIN". This change appears to align with recent project standards. Please confirm that this update propagates consistently across the application.
327-335: New Required Target Field Added for LLIN BoundaryWithTarget
A new property named"HCM_ADMIN_CONSOLE_TARGET"(with bounds, minimum 1 and maximum 100000000, and set as required) has been added in the LLIN boundaryWithTarget definition. Ensure that this stricter validation meets the intended business requirements and that any consumers of this schema are updated accordingly.
367-367: Update Campaign Type for LLIN BoundaryWithTarget
Similar to the boundary object, the boundaryWithTarget entry now has"campaignType": "LLIN". This uniform naming helps align schemas across modules. Please verify that this change doesn’t affect any backward compatibility or integration tests.localisation/HCM Admin Console/v0.3.1 patch/en_MZ/hcm-campaignmanager.json (1)
2-7: New Localization Entry Added for en_MZ
A new entry for the code"CAMPAIGN_DELIVERY_TAB_SUB_TEXT_LLIN"has been inserted with the message"Configure delivery condition for LLIN Campaign". Confirm that this label correctly reflects the intended user-facing text and is consistent with other localization entries.localisation/HCM Admin Console/v0.3.1 patch/pt_MZ/hcm-campaignmanager.json (1)
2-7: New Localization Entry Added for pt_MZ
The new entry for"CAMPAIGN_DELIVERY_TAB_SUB_TEXT_LLIN"now appears with the message"Configurar condição de entrega para campanha LLIN", which is appropriate for the Portuguese (Mozambique) locale.
Summary by CodeRabbit
New Features
Refactor