fix(refs): refs dont have metadata

src/instantiation/Ref.test.ts

@@ -1,3 +1,4 @@
+import { omitReadonly } from '../manipulation/omitReadonly';
 import { isRefByPrimary } from '../reference/isRefByPrimary';
 import { isRefByUnique } from '../reference/isRefByUnique';
 import { DomainEntity } from './DomainEntity';
@@ -268,5 +269,19 @@ describe('Ref', () => {
         expect(ref.turtle).not.toHaveProperty('uuid');
       });
     });
+
+    it('should not omit anything when omitReadonly is called, since refs have no metadata', () => {
+      const ref = new Ref<typeof SeaTurtle>({
+        seawaterSecurityNumber: '821',
+      });
+
+      const refWithoutReadonly = omitReadonly(ref);
+
+      // all properties should be preserved since Ref has metadata = []
+      if (!isRefByUnique({ of: SeaTurtle })(refWithoutReadonly))
+        throw new Error('expected ref to be by unique');
+      expect(refWithoutReadonly.seawaterSecurityNumber).toBe('821');
+      expect(refWithoutReadonly).toBeInstanceOf(Ref);
+    });
   });
 });

src/instantiation/Ref.ts

@@ -34,6 +34,8 @@ export type Ref<
 
 // extend the domain literal into a custom class, so that we can rename it into Ref, without mutating the global DomainLiteral class
 class RefBase<T extends DomainObjectShape> extends DomainLiteral<T> {
+  public static metadata = [] as const;
+
   constructor(props: T) {
     // if props itself is a domain entity or domain event, extract its reference (using unique keys as the default)
     if (isOfDomainEntity(props) || isOfDomainEvent(props)) {

src/instantiation/RefByPrimary.test.ts

@@ -1,5 +1,6 @@
 import type { HasMetadata, OmitMetadata } from 'type-fns';
 
+import { omitReadonly } from '../manipulation/omitReadonly';
 import { DomainEntity } from './DomainEntity';
 import { DomainLiteral } from './DomainLiteral';
 import { RefByPrimary } from './RefByPrimary';
@@ -273,5 +274,19 @@ describe('DomainRefByPrimary', () => {
         expect(home.turtle).not.toHaveProperty('seawaterSecurityNumber');
       });
     });
+
+    it('should not omit anything when omitReadonly is called, since refs have no metadata', () => {
+      const ref = new RefByPrimary<typeof SeaTurtle>({
+        uuid: '123e4567-e89b-12d3-a456-426614174000',
+      });
+
+      const refWithoutReadonly = omitReadonly(ref);
+
+      // all properties should be preserved since RefByPrimary has metadata = []
+      expect(refWithoutReadonly.uuid).toBe(
+        '123e4567-e89b-12d3-a456-426614174000',
+      );
+      expect(refWithoutReadonly).toBeInstanceOf(RefByPrimary);
+    });
   });
 });

src/instantiation/RefByPrimary.ts

@@ -33,6 +33,8 @@ export type RefByPrimary<
 
 // extend the domain literal into a custom class, so that we can rename it into RefByUnique, without mutating the global DomainLiteral class
 class RefByPrimaryBase<T extends DomainObjectShape> extends DomainLiteral<T> {
+  public static metadata = [] as const;
+
   constructor(props: T) {
     // if props itself is a domain entity or domain event, extract its reference
     if (

src/instantiation/RefByUnique.test.ts

@@ -1,3 +1,4 @@
+import { omitReadonly } from '../manipulation/omitReadonly';
 import { DomainEntity } from './DomainEntity';
 import { DomainLiteral } from './DomainLiteral';
 import { Ref } from './Ref';
@@ -229,5 +230,17 @@ describe('DomainRefByUnique', () => {
         );
       });
     });
+
+    it('should not omit anything when omitReadonly is called, since refs have no metadata', () => {
+      const ref = new RefByUnique<typeof SeaTurtle>({
+        seawaterSecurityNumber: '821',
+      });
+
+      const refWithoutReadonly = omitReadonly(ref);
+
+      // all properties should be preserved since RefByUnique has metadata = []
+      expect(refWithoutReadonly.seawaterSecurityNumber).toBe('821');
+      expect(refWithoutReadonly).toBeInstanceOf(RefByUnique);
+    });
   });
 });

src/instantiation/RefByUnique.ts

@@ -34,6 +34,8 @@ export type RefByUnique<
 
 // extend the domain literal into a custom class, so that we can rename it into RefByUnique, without mutating the global DomainLiteral class
 class RefByUniqueBase<T extends DomainObjectShape> extends DomainLiteral<T> {
+  public static metadata = [] as const;
+
   constructor(props: T) {
     // if props itself is a domain entity or domain event, extract its reference
     if (isOfDomainEntity(props) || isOfDomainEvent(props)) {