Skip to content

Conversation

@simonge
Copy link
Contributor

@simonge simonge commented Nov 7, 2025

Briefly, what does this PR introduce?

Creates the volumes of the dipole magnets in the far backward region.

Currently in the wrong position, this will be updated to the correct location, or merged into a separate PR when the beamline changes have been made.

Opened to check the naming of the components, materials are appropriate and the simplification of the CAD geometry is acceptable.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@simonge simonge requested a review from nat93 November 7, 2025 10:34
@simonge
Copy link
Contributor Author

simonge commented Nov 7, 2025

Simulation has all of the magnet volume as iron.
image
CAD images:
image
image

@nat93
Copy link
Contributor

nat93 commented Nov 7, 2025

Hi @simonge ,
Thanks for implementing this. I have a couple of questions:

  1. Why did you change the magnet names? In the lattice and drawings, we usually call them B2AeR and B2BeR. I would suggest following the same naming convention in DD4hep.
  2. What does “Bar” refer to?

Thanks

@simonge
Copy link
Contributor Author

simonge commented Nov 7, 2025

Thanks @nat93

  1. Why did you change the magnet names? In the lattice and drawings, we usually call them B2AeR and B2BeR. I would suggest following the same naming convention in DD4hep.

My mistake, now hopefully named consistently.

  1. What does “Bar” refer to?

Bar was the name I gave to the rectangular objects in the B2BeR geometry, I was hoping you could provide more appropriate names for each part of the magnet so very happy if you have the correct names and materials to swap in.

@nat93
Copy link
Contributor

nat93 commented Nov 7, 2025

Thanks @nat93

  1. Why did you change the magnet names? In the lattice and drawings, we usually call them B2AeR and B2BeR. I would suggest following the same naming convention in DD4hep.

My mistake, now hopefully named consistently.

  1. What does “Bar” refer to?

Bar was the name I gave to the rectangular objects in the B2BeR geometry, I was hoping you could provide more appropriate names for each part of the magnet so very happy if you have the correct names and materials to swap in.

@simonge ,
Ah, I see. Those objects should be magnet coils. For now, we can model them as copper, but later, when I start looking into TID and heat-load calculations in that region and Harshita has a more detailed model, I may refine it by adding epoxy resin and a realistic coil geometry for both magnets.

nat93
nat93 previously approved these changes Nov 7, 2025
Copy link
Contributor

@nat93 nat93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change "Bar" to "Coils". The rest is fine. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants