-
Notifications
You must be signed in to change notification settings - Fork 54
New far backward dipole magnet volumes added #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
|
Hi @simonge ,
Thanks |
|
Thanks @nat93
My mistake, now hopefully named consistently.
Bar was the name I gave to the rectangular objects in the B2BeR geometry, I was hoping you could provide more appropriate names for each part of the magnet so very happy if you have the correct names and materials to swap in. |
@simonge , |
nat93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change "Bar" to "Coils". The rest is fine. Thank you!
…:eic/epic into Add-dipole-steering-magnets-based-on-CAD



Briefly, what does this PR introduce?
Creates the volumes of the dipole magnets in the far backward region.
Currently in the wrong position, this will be updated to the correct location, or merged into a separate PR when the beamline changes have been made.
Opened to check the naming of the components, materials are appropriate and the simplification of the CAD geometry is acceptable.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?