Skip to content

Document stale-while-revalidate#154

Merged
wkillerud merged 1 commit intosourcefrom
stale-while-revalidate
Oct 13, 2025
Merged

Document stale-while-revalidate#154
wkillerud merged 1 commit intosourcefrom
stale-while-revalidate

Conversation

@wkillerud
Copy link
Contributor

@wkillerud wkillerud commented Oct 13, 2025

Minimal docs for eik-lib/service#688

Copy link
Contributor

@leftieFriele leftieFriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
Only thing I was thinking of was wether we should advise on using this and name the current approach as "legacy" or similar to indicate that the stale-while-revalidate is the better option.

@trygve-lie
Copy link
Contributor

Only thing I was thinking of was wether we should advise on using this and name the current approach as "legacy" or similar to indicate that the stale-while-revalidate is the better option.

Lets test it a bit in prod first.

Copy link
Contributor

@trygve-lie trygve-lie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@wkillerud
Copy link
Contributor Author

Only thing I was thinking of was wether we should advise on using this and name the current approach as "legacy" or similar to indicate that the stale-while-revalidate is the better option.

For sure, but I wanted to do that down the line once we've gotten some prod experience with it. Stale-while-revalidate should perform better for most global users, so it's a sensible default for docs in not too long.

@wkillerud wkillerud merged commit c26bd67 into source Oct 13, 2025
4 checks passed
@wkillerud wkillerud deleted the stale-while-revalidate branch October 13, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants