Generalize clipboard feature for platform independence#1
Open
torarvid wants to merge 1 commit intoeinaros:masterfrom
Open
Generalize clipboard feature for platform independence#1torarvid wants to merge 1 commit intoeinaros:masterfrom
torarvid wants to merge 1 commit intoeinaros:masterfrom
Conversation
The copyToClipboard function would fail unless the platform was Mac OS X (Or, strictly speaking, if there was no 'pbcopy' binary available). This patch fixes it so the code runs on Windows. For any other platform it will now be a noop (which I think is better than having it crash which was the case before..)
Author
|
@einaros Any chance you have time to look at my PR soon? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copyToClipboard function would fail unless the platform was Mac OS X
(Or, strictly speaking, if there was no 'pbcopy' binary available). This
patch fixes it so the code runs on Windows. For any other platform it will
now be a noop (which I think is better than having it crash which was the
case before..)