Fixing a bug in Meth() #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data[,item] creates a 1 column data.frame. This creates an error in make.repl() since the data.frame passed to this function will have an item with the wrong name. data.frame(item=item) ignores the tag if item is a data.frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to run
MethComp::Meth(data, y=c('co_ref', 'co_exp'), item = 'id')This gave an error, because of line#123 make.repl( data.frame(meth=rep(1,Nr),item=item) )
The function expects a data.frame with a column named "item", however, when data.frame(...) is passed a data.frame (here data[,item]) it will use the names in this data.frame instead.
These changes fixed the issue and it works with
MethComp::Meth(data, y=c('co_ref', 'co_exp'), item = 'id', repl = 'time').I have not tested it with other combinations of parameters.