fix: unify extract-log-errors output behavior for empty manifests#814
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Draft
fix: unify extract-log-errors output behavior for empty manifests#814github-actions[bot] wants to merge 2 commits intomainfrom
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
Ensure empty and non-empty log flows use the same output writer so --output behavior is consistent and path reporting is preserved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves issue #812 by removing redundant empty-branch output handling in
scripts/extract-log-errors.pyand routing both empty and non-empty executions through the sameemit_output(...)path.What changed
emit_empty_output(...).main()so it always builds asummaryand always callsemit_output(summary, args.output).No log files found.) for empty inputs.Tests
tests/test_extract_log_errors.pyto verify--outputprints the output path for both:/tmp/gh-aw/agent/venv/bin/python -m pytest -q tests/test_extract_log_errors.py4 passedIssue linkage
Closes #812.
Note
🔒 Integrity filtering filtered 31 items
Integrity filtering activated and filtered the following items during workflow execution.
This happens when a tool call accesses a resource that does not meet the required integrity or secrecy level of the workflow.
issue_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)/aicommand, causing duplicate work #811 (list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)fetch-workflow-logs.py --last 0still returns one run #810 (list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)What is this? | From workflow: Trigger Code Complexity Detector
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.