-
Notifications
You must be signed in to change notification settings - Fork 171
[Lens] Page for Metric charts #3645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lens-charts-all
Are you sure you want to change the base?
[Lens] Page for Metric charts #3645
Conversation
🔍 Preview links for changed docs |
…s-content into metrics-charts-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @florent-leborgne great progress on this. I just left a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gvnmagni I don't think this is the green from our palette, is it? can we provide @florent-leborgne the same metric with the right color?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
|  | ||
|
|
||
| ## When to use metric charts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the issue, let's remove this section entirely :)
| * **Static**: Shows the secondary metric as a badge with a single color that you select | ||
| * **Dynamic**: Enables both color coding and directional icons based on the comparison | ||
|
|
||
| 4. Select **Dynamic** coloring. More options appear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really think we need a screenshot here it's super difficult to find this option. I spent a lot of time the first time I used this. Until we can fix this problem let's at least document it.
| - **Label position**: Choose to show the label **Before** or **After** the metric. | ||
| - **Color by value**: Apply colors to the chart. Choose between **None**, **Static** for a unique color and **Dynamic** for using different colors based on the metric's value. This option allows you to use the secondary metric as a comparison point to highlight trends. Refer to [](#metric-trends) for more details. | ||
|
|
||
| ### Maximum value settings [max-value-options] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a screenshot here too, this is an important setting and not very easy to use
|
|
||
| The following examples show various configuration options that you can use for building impactful metrics. | ||
|
|
||
| **Executive dashboard KPI** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's replace this with an O11y example
|
|
||
|  | ||
|
|
||
| **Sales per day of the week** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this with an observability example

Fixes #2543
Here is a draft of a page for metrics charts. Would like reviewers to advise on anything missing and inaccuracies in particular for the settings part where there may be more nuance to add in some places.
Let's finetune what we can and once we have a few different chart pages ready, we can release in small batches
Done:
Missing:
refine examples (various use cases but also various configuration setups)Donevisuals for examplesDoneadd some advanced, undocumented options that don't look so simple for defining valuesDone