[Do not merge] Convert tabs that can be applies-switch #4429
Conversation
Vale Linting ResultsSummary: 2 warnings, 23 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.BritishSpellings | Use American English spelling 'toward' instead of British English 'towards'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.BritishSpellings | Use American English spelling 'toward' instead of British English 'towards'. |
💡 Suggestions (23)
| File | Line | Rule | Message |
|---|---|---|---|
| deploy-manage/users-roles/cluster-or-deployment-auth/saml.md | 425 | Elastic.Acronyms | 'PEM' has no definition. |
| deploy-manage/users-roles/cluster-or-deployment-auth/saml.md | 540 | Elastic.Acronyms | 'SAML' has no definition. |
| troubleshoot/elasticsearch/increase-capacity-data-node.md | 21 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-capacity-data-node.md | 57 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-capacity-data-node.md | 57 | Elastic.FutureTense | 'will need' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/increase-cluster-shard-limit.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-cluster-shard-limit.md | 81 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-shard-limit.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-shard-limit.md | 82 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-tier-capacity.md | 27 | Elastic.FutureTense | 'will increase' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/increase-tier-capacity.md | 139 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/repeated-snapshot-failures.md | 27 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/restore-from-snapshot.md | 27 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/restore-from-snapshot.md | 231 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.FutureTense | 'will resolve' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.FutureTense | 'will also' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.FutureTense | 'will resolve' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.FutureTense | 'will also' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/observability/apm/apm-server-response-codes.md | 20 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI. |
| troubleshoot/observability/apm/apm-server-response-codes.md | 24 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI. |
| troubleshoot/observability/troubleshoot-logs.md | 49 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'see', unless the term is in the UI. |
|
Edit: found ittttt |
…-leborgne/docs-content into convert-tabs-into-applies-switch
|
@florent-leborgne , what kind of reviews do you want on this? It's not the typical PR so I'm just thinking about how best to go about it 🕵️ |
shainaraskas
left a comment
shainaraskas
left a comment
There was a problem hiding this comment.
most of this looks good, but please skip the elasticsearch troubleshooting content. I'll need to fix it with the page-level issues
| :::::: | ||
|
|
||
| ::::::{tab-item} Self-managed | ||
| ::::::{applies-item} self: |
There was a problem hiding this comment.
I think this is a case where self-managed is used as shorthand for ece eck self ... I can't be sure about this because I don't know how ECE handles this. maybe we need an issue to double-check this
There was a problem hiding this comment.
Yes I saw a few like this - it will still say the same "Self-managed", but in a badge so I don't think this is blocking, but should definitely be checked. Is that with your team? I remember Marci working on time series, maybe she'd know for this one?
There was a problem hiding this comment.
it's us or dev (snapshots is us, ilm is them ...)
I know for sure that this needs work. opening an issue for it
|
as a side note, there's only maybe a handful of things in here with a range ... this could be split and most of it could be merged ASAP |
…abs-into-applies-switch
leemthompo
left a comment
leemthompo
left a comment
There was a problem hiding this comment.
2 dev docs files lgtm
mdbirnstiehl
left a comment
mdbirnstiehl
left a comment
There was a problem hiding this comment.
LGTM for the most part, let me know if you want me to handle the comment I made.
|
|
||
| :::{tab-item} Elastic Stack | ||
| :sync: stack | ||
| :::{applies-item} stack: |
There was a problem hiding this comment.
Looks like the content in serverless and stack is identical here, not sure if that's out of the scope of this PR, if so, I can make the update in another PR.
5 participants
Summary
This PR converts tabs that should now be applies-switch thanks to the recent and upcoming updates to the metadata system.
This PR should only be merged after elastic/docs-builder#2322 is merged.
CI should fail until then.
Contributes to: #4361
Generative AI disclosure