-
Notifications
You must be signed in to change notification settings - Fork 191
[do not merge] check multi value applies-to and lists #4431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d467a19
d9f55a2
486e8e3
41eed95
7523b26
78d2ec9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -233,7 +233,7 @@ The following settings are supported: | |
| `get_register_retry_delay` | ||
| : ([time value](elasticsearch://reference/elasticsearch/rest-apis/api-conventions.md#time-units)) Sets the time to wait before trying again if an attempt to read a [linearizable register](#repository-s3-linearizable-registers) fails. Defaults to `5s`. | ||
|
|
||
| `unsafely_incompatible_with_s3_conditional_writes` {applies_to}`stack: ga 9.2.3` | ||
| `unsafely_incompatible_with_s3_conditional_writes` {applies_to}`stack: ga 9.2.3+!` | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. probably practicing what we preach here, I'd just skip the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because it's isolated and isn't a multi-patch scenario we can afford to use it though I have no strong feeling about removing it. Lmk your preference and i'll adjust |
||
| : (boolean) {{es}} uses AWS S3's support for conditional writes to protect against repository corruption. If your repository is based on a storage system which claims to be S3-compatible but does not accept conditional writes, set this setting to `true` to make {{es}} perform unconditional writes, bypassing the repository corruption protection, while you work with your storage supplier to address this incompatibility with AWS S3. Defaults to `false`. | ||
|
|
||
| ::::{note} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we talked about not explicitly documenting this / documenting it as something that should be handled in prose - it doesn't play nice with ranges so I don't know that we want to expose it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm totally open to removing this, cc @elastic/docs-tech-leads