Skip to content

otel(tests): skip flaky assertion in TestContainerCMDAgentMonitoringRuntimeExperimental #11231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2025
Merged

otel(tests): skip flaky assertion in TestContainerCMDAgentMonitoringRuntimeExperimental #11231

merged 3 commits into from
Nov 20, 2025

Conversation

@mauri870
Copy link
Member

@mauri870 mauri870 commented Nov 18, 2025 •
edited
Loading

What does this PR do?

These tests are currently flaky because the http/metrics-monitoring version info returned by the test fixture is sometimes empty, causing the entire test to fail. Update the tests to skip checking this particular component. It doesn't affect the overall purpose of the test, which is to verify that the correct agent.monitoring runtime is used, and we can rely on the other monitoring components for that.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

@mauri870 mauri870 self-assigned this Nov 18, 2025
@mauri870 mauri870 added Cleanup skip-changelog backport-active-all Automated backport with mergify to all the active branches labels Nov 18, 2025
@mauri870 mauri870 marked this pull request as ready for review November 18, 2025 12:35
@mauri870 mauri870 requested a review from a team as a code owner November 18, 2025 12:35
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Nov 18, 2025
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 18, 2025

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@mauri870
Copy link
Member Author

mauri870 commented Nov 18, 2025

/test

@mauri870 mauri870 enabled auto-merge (squash) November 18, 2025 15:36
@mauri870
Copy link
Member Author

mauri870 commented Nov 19, 2025

It seems TestFleetManagedUpgradeRollbackOnRestarts is still causing failures which prevents me from merging this PR. Tracked by #10917.

@pchila
Copy link
Member

pchila commented Nov 20, 2025

It seems TestFleetManagedUpgradeRollbackOnRestarts is still causing failures which prevents me from merging this PR. Tracked by #10917.

It has been fixed with #11218

@mauri870 mauri870 merged commit 259dd3e into elastic:main Nov 20, 2025
21 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

@Mergifyio backport 8.19 9.1 9.2

@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025 •
edited
Loading

backport 8.19 9.1 9.2

✅ Backports have been created

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 20, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @mauri870

mergify bot pushed a commit that referenced this pull request Nov 20, 2025
@mauri870 @mergify
otel(tests): skip flaky assertion in TestContainerCMDAgentMonitoringR…
fbe2ace 
…untimeExperimental (#11231)

(cherry picked from commit 259dd3e)
mergify bot pushed a commit that referenced this pull request Nov 20, 2025
@mauri870 @mergify
otel(tests): skip flaky assertion in TestContainerCMDAgentMonitoringR…
20b1d23 
…untimeExperimental (#11231)

(cherry picked from commit 259dd3e)
mergify bot pushed a commit that referenced this pull request Nov 20, 2025
@mauri870 @mergify
otel(tests): skip flaky assertion in TestContainerCMDAgentMonitoringR…
0df2441 
…untimeExperimental (#11231)

(cherry picked from commit 259dd3e)
This was referenced Nov 20, 2025
Merged
Merged
Merged
mauri870 added a commit that referenced this pull request Nov 21, 2025
@mergify @mauri870
otel(tests): skip flaky assertion in TestContainerCMDAgentMonitoringR…
4e597bc 
…untimeExperimental (#11231) (#11301)

(cherry picked from commit 259dd3e)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Nov 21, 2025
@mergify @mauri870
otel(tests): skip flaky assertion in TestContainerCMDAgentMonitoringR…
e2cf65f 
…untimeExperimental (#11231) (#11302)

(cherry picked from commit 259dd3e)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Nov 21, 2025
@mergify @mauri870
otel(tests): skip flaky assertion in TestContainerCMDAgentMonitoringR…
15fa464 
…untimeExperimental (#11231) (#11303)

(cherry picked from commit 259dd3e)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
hayotbisonai pushed a commit to hayotbisonai/elastic-agent that referenced this pull request Nov 23, 2025
@mauri870 @hayotbisonai
otel(tests): skip flaky assertion in TestContainerCMDAgentMonitoringR…
d82e4ce 
…untimeExperimental (elastic#11231)
swiatekm pushed a commit that referenced this pull request Nov 24, 2025
@mauri870 @swiatekm
otel(tests): skip flaky assertion in TestContainerCMDAgentMonitoringR…
d30092c 
…untimeExperimental (#11231)
@mauri870 mauri870 mentioned this pull request Nov 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakerouse blakerouse blakerouse approved these changes

@swiatekm swiatekm swiatekm approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@mauri870 mauri870

Labels

backport-active-all Automated backport with mergify to all the active branches Cleanup skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

6 participants

@mauri870 @elasticmachine @pchila @blakerouse @swiatekm @pierrehilbert