Skip to content

Conversation

@flobernd
Copy link
Member

@flobernd flobernd commented Oct 20, 2025

The specification uses Dictionary<string, UserDefinedValue> in many places to indicate that the server returns an "arbitrary" JSON object.

This PR introduces a new alias type UserDefinedObject that should instead be used for this purpose, because:

  1. The descriptive name ensures that the semantics are clear
  2. The alias type allows generators to replace the type with a more natural one, if needed (see e.g. Provide a helper for reading selected fields from search response elasticsearch-net#8758)

@flobernd flobernd force-pushed the user-defined-object branch 4 times, most recently from 063d015 to 705ebd2 Compare October 20, 2025 08:50
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@flobernd flobernd marked this pull request as ready for review October 20, 2025 09:39
@flobernd flobernd requested review from a team as code owners October 20, 2025 09:39
@flobernd flobernd added the skip-backport This pull request should not be backported label Oct 20, 2025
@flobernd flobernd requested review from a team, Anaethelion, l-trotta and pquentin October 20, 2025 09:40
Copy link
Member

@qn895 qn895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML UI: LGTM 🎉

@flobernd
Copy link
Member Author

@l-trotta @Anaethelion Would you be fine with backporting this to 8.19 and potentially 9.2?

@l-trotta
Copy link
Contributor

yep java resolves all aliases so this changes nothing for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-backport This pull request should not be backported specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants