- 
                Notifications
    You must be signed in to change notification settings 
- Fork 116
Add support for multiple Google Model Garden providers for completion and chat_completion tasks #5532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… and chat_completion tasks
| Following you can find the validation changes against the target branch for the APIs. 
 You can validate these APIs yourself by using the  | 
| @@ -0,0 +1,14 @@ | |||
| summary: A completion task for Google Model Garden Meta endpoint with single URL provided | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add examples of the other providers?
That way it'll be more clear when a user needs to include url vs url and streaming_url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added examples for the rest of the providers.
| export enum GoogleModelGardenProvider { | ||
| google, | ||
| anthropic | ||
| anthropic, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add in the url and streaming_url field comments which providers require which ones? (basically the same thing we did in the comment in the Java code).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
…odel Garden providers with single and separate streaming URLs
| @jonathan-buttner your comments are addressed. Could you please take another look at this PR? | 
| "provider": "mistral", | ||
| "model_id": "mistral-small-2503", | ||
| "service_account_json": "service-account-json", | ||
| "streaming_url": "https://url:streamRawPredict" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these examples. Is there anymore information we can give the user to help aid them in finding these URLs? Is there a general place where they can find them (like after creating the model garden endpoint, go to this tab to find the base url and you'll need to add :streamRawPredict to the end etc).
I'm not sure if the best place for that is here in the examples though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve updated the documentation with the following changes:
- Added more examples covering each provider’s serverless, dedicated, and shared endpoints.
- Included specific URL patterns in the url and streaming_url fields for each example.
- Added details on where to find the variables used to construct these URLs in each example.
- Updated the descriptions of the url and streaming_url fields with general guidance on where to find URL construction information (in the Google Model Garden documentation for the model, or on the endpoint’s Sample request page).
…oogle Model Garden providers with updated URL formats
This PR adds changes to specification caused by elastic/elasticsearch#135701
Additional actions