-
Notifications
You must be signed in to change notification settings - Fork 115
Add optional request bodies to three ML APIs #5752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,4 +76,36 @@ export interface Request extends RequestBase { | |
| */ | ||
| timeout?: Duration | ||
| } | ||
| body?: { | ||
| /** | ||
| * If provided, must be the same identifier as in the path. | ||
| */ | ||
| id?: Id | ||
| /** | ||
| * Specifies what to do when the request: | ||
| * | ||
| * 1. Contains wildcard expressions and there are no data frame analytics | ||
| * jobs that match. | ||
| * 2. Contains the _all string or no identifiers and there are no matches. | ||
| * 3. Contains wildcard expressions and there are only partial matches. | ||
| * | ||
| * The default value is true, which returns an empty data_frame_analytics | ||
| * array when there are no matches and the subset of results when there are | ||
| * partial matches. If this parameter is false, the request returns a 404 | ||
| * status code when there are no matches or only partial matches. | ||
| * @server_default true | ||
| */ | ||
| allow_no_match?: boolean | ||
| /** | ||
| * If true, the data frame analytics job is stopped forcefully. | ||
| * @server_default false | ||
| */ | ||
| force?: boolean | ||
| /** | ||
| * Controls the amount of time to wait until the data frame analytics job | ||
| * stops. Defaults to 20 seconds. | ||
| * @server_default 20s | ||
| */ | ||
| timeout?: Duration | ||
| } | ||
|
Comment on lines
+79
to
+110
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,4 +59,24 @@ export interface Request extends RequestBase { | |
| */ | ||
| force?: boolean | ||
| } | ||
| body?: { | ||
| /** | ||
| * If provided, must be the same identifier as in the path. | ||
| */ | ||
| id?: Id | ||
| /** | ||
| * Specifies what to do when the request: contains wildcard expressions and there are no deployments that match; | ||
| * contains the `_all` string or no identifiers and there are no matches; or contains wildcard expressions and | ||
| * there are only partial matches. By default, it returns an empty array when there are no matches and the subset of results when there are partial matches. | ||
| * If `false`, the request returns a 404 status code when there are no matches or only partial matches. | ||
| * @server_default true | ||
| */ | ||
| allow_no_match?: boolean | ||
| /** | ||
| * Forcefully stops the deployment, even if it is used by ingest pipelines. You can't use these pipelines until you | ||
| * restart the model deployment. | ||
| * @server_default false | ||
| */ | ||
| force?: boolean | ||
| } | ||
|
Comment on lines
+62
to
+81
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
body is read here: https://github.com/elastic/elasticsearch/blob/4381faec9ab38dcca287e1d2d0e1da481afbe147/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/rest/dataframe/RestStartDataFrameAnalyticsAction.java#L42C25-L44
using this parser: https://github.com/elastic/elasticsearch/blob/4381faec9ab38dcca287e1d2d0e1da481afbe147/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/action/StartDataFrameAnalyticsAction.java#L53-L56