Skip to content

Conversation

@Jan-Kazlouski-elastic
Copy link
Contributor

@Jan-Kazlouski-elastic Jan-Kazlouski-elastic commented Nov 13, 2025

This PR adds the spec file that was added in this PR:

Specification PR elastic/elasticsearch-specification#5662

  • - Have you signed the contributor license agreement?
  • - Have you followed the contributor guidelines?
  • - If submitting code, have you built your formula locally prior to submission with gradle check?
  • - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • - If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • - If you are submitting this code for a class then read our policy for that.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.3.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 13, 2025
@Jan-Kazlouski-elastic
Copy link
Contributor Author

This PR is to be merged only after:

If there are changes to Specification PR - this PR also needs to be updated accordingly.

Labels are to be taken from similar PR:
#132724

CC @DonalEvans

@DonalEvans DonalEvans self-assigned this Nov 13, 2025
@DonalEvans DonalEvans added >non-issue :ml Machine learning Team:ML Meta label for the ML team labels Nov 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

"methods": ["PUT"],
"parts": {
"task_type": {
"type": "string",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "enum"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time this PR was opened, task_type was still defined as a string in every other place. It was converted to an enum in other parts of the codebase during the time this PR was awaiting review. I’ve updated this PR accordingly to align with the latest changes. Thanks.

Comment on lines 20 to 21
"type": "string",
"description": "The task type"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the "type" and "description" fields, I think there should be an "options" one listing the valid values for "task_type" for this integration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here. It was added in other parts of the codebase during the time this PR was awaiting review. I’ve updated this PR accordingly to align with the latest changes. Thanks.

@DonalEvans DonalEvans merged commit 7e73dc4 into elastic:main Nov 18, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team :ml Machine learning >non-issue Team:ML Meta label for the ML team v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants