-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add OpenShift AI REST API specification #138025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenShift AI REST API specification #138025
Conversation
|
This PR is to be merged only after:
If there are changes to Specification PR - this PR also needs to be updated accordingly. Labels are to be taken from similar PR: CC @DonalEvans |
|
Pinging @elastic/ml-core (Team:ML) |
| "methods": ["PUT"], | ||
| "parts": { | ||
| "task_type": { | ||
| "type": "string", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be "enum"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the time this PR was opened, task_type was still defined as a string in every other place. It was converted to an enum in other parts of the codebase during the time this PR was awaiting review. I’ve updated this PR accordingly to align with the latest changes. Thanks.
| "type": "string", | ||
| "description": "The task type" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the "type" and "description" fields, I think there should be an "options" one listing the valid values for "task_type" for this integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here. It was added in other parts of the codebase during the time this PR was awaiting review. I’ve updated this PR accordingly to align with the latest changes. Thanks.
This PR adds the spec file that was added in this PR:
Specification PR elastic/elasticsearch-specification#5662
gradle check?