[Fleet] Fix monitoring.enabled for agentless

[nchaulet]

Summary

Disabling monitoring for agentless had the unwanted side effect of disabling the http monitoring server.

We had the similar issue with could policies and it was mitigated by adding the keep_monitoring_alive flag.

That PR enable that flag for all the agentless flag

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[jen-huang]

Disabling monitoring for agentless had the unwanted side effect of disabling the http monitoring server.

Do we need monitoring.http.enabled to start the server or is the top-level monitoring.enabled: true enough? keep_monitoring_alive only seems to enable the latter, so I'm wondering if it is enough:

kibana/x-pack/platform/plugins/shared/fleet/server/services/agent_policies/full_agent_policy.ts

Line 765 in afbe65e

if (agentPolicy.monitoring_http?.enabled) {

[nchaulet]

Do we need monitoring.http.enabled to start the server or is the top-level monitoring.enabled: true enough? keep_monitoring_alive only seems to enable the latter, so I'm wondering if it is enough:

That a good point agentless has monitoring.http.enabled on the local config file but not sure it's enough, I will test it

Edit: @jen-huang it seems it will keep the value from the file as they are not overided by the fleet config (it's what it's happening in cloud)

[jen-huang]

I pulled locally and I see this in the agent yml with default agentless policy settings which looks expected based on the changes here:

agent:
  monitoring:
    enabled: true
    logs: false
    metrics: false
    traces: false

I updated the monitoring settings for the policy to explicitly enable the http endpoint:

(not sure we should allow these to be editable for agentless policies, but that's a different issue 😅)

the saved object becomes:

        "monitoring_enabled": [],
        "keep_monitoring_alive": true,
        "monitoring_http": {
            "host": "localhost",
            "port": 6791,
            "enabled": true
        },

and the agent yml becomes:

agent:
  monitoring:
    enabled: true
    logs: false
    metrics: false
    traces: false
    http:
      enabled: true
      host: localhost
      port: 6791

@nchaulet So you're saying that agent.monitoring.enabled means that agent.monitoring.http.enabled is also enabled without it being set explicitly? Just want to triple check my understanding.

Also spotted this when I tried to look at the agent yml (with http turned on), but download yml works fine, and it happens for regular agent policies too so it's probably not related to the changes here - I'll take a look at this separately:

[nchaulet]

(not sure we should allow these to be editable for agentless policies, but that's a different issue 😅)

Yes that another reason to have a dedicated API for agentless policies and do not allow to edit their agent policies #240879

@nchaulet So you're saying that agent.monitoring.enabled means that agent.monitoring.http.enabled is also enabled

Not really the agent.monitoring.enabled work in combination with agent.monitoring.http.enabled being explicitly set in the agent config file locally.

[nchaulet]

@elasticmachine merge upstream

[elasticmachine]

⏳ Build in-progress, with failures

• Buildkite Build
• Commit: 2594389

Failed CI Steps

• Jest Integration Tests #8
• Jest Integration Tests #8
• Scout Test Run Builder

Test Failures

• [job] [logs] Jest Integration Tests #8 / daily rollups integration test deletes documents older that 3 days from the saved objects repository
• [job] [logs] Jest Integration Tests #8 / daily rollups integration test deletes documents older that 3 days from the saved objects repository
• [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiDataGrid - data grid, run

History

• 💛 Build #357341 was flaky 3aa115d

[nchaulet]

@elasticmachine merge upstream

[nchaulet]

we decided the fix will be in agentless agent where, the agent will honor the config on disk, so no need to modify Kibana, it will be more future proof as we could easily fix any config issue for agentless controller instead of relying on a Kibana release