Backport CLI refactor #968
Open
+201
−179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Closing and re-opening to trigger GH workflow... |
Contributor
|
@NickDris We can avoid running GH workflow for labelling and reminding if we add an additional check in the workflow for the PR merge status. PRs can get closed without merge for various reasons, like here. |
gbanasiak
reviewed
Jan 5, 2026
| remove_clause="${{ github.event.inputs.remove == 'true' && '--remove' || '' }}" | ||
| python github_ci_tools/scripts/backport.py $pr_number_clause label --lookback-days ${{ github.event.inputs.lookback_days || '7' }} $remove_clause | ||
| python github_ci_tools/scripts/backport.py $pr_number_clause remind --pending-reminder-age-days ${{ github.event.inputs.pending_label_age_days || '14' }} $remove_clause | ||
| python github_ci_tools/scripts/backport.py $pr_number_clause remind --lookback-days ${{ github.event.inputs.lookback_days || '7' }} --pending-reminder-age-days ${{ github.event.inputs.pending_label_age_days || '14' }} $remove_clause |
Contributor
There was a problem hiding this comment.
Default lookback interval should be greater than reminder interval. This should also be validated in the tool when custom values are provided.
Comment on lines
+87
to
+90
| "**How to proceed:**\n" | ||
| " - If it is intended for the current or next Elasticsearch release minor version, apply the corresponding version label.\n" | ||
| " - If it also supports past released versions, add those labels too.\n" | ||
| " - If it only targets a future version, wait until that version label exists and then add it.\n" | ||
| " (Each rally-tracks version label is created during the feature freeze of a new Elasticsearch branch).\n\n" | ||
| "Backporting entails: \n" | ||
| " - If it introduces functionality dependent on future versions, please wait until the relevant `vX.Y` label is created. In such cases, retain the `backport pending` label to enable periodic notifications.\n" |
Contributor
There was a problem hiding this comment.
I think this can be simplified as per https://github.com/elastic/rally-teams/pull/111/files#r2660773161, i.e. there is no need to wait for vX.Y label because there should always be the next version label available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport.pybased on comments