It always shows mirror failures when there is any. #2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fressi-elastic
changed the title
fressi-elastic
changed the title
There was a problem hiding this comment.
Pull request overview
This PR modifies the esrally-storage ls command to always display mirror failures when they exist, eliminating the need for the --mirror-failures flag to control output visibility. The --mirror-failures flag is repurposed to filter which transfers are displayed (showing only those with mirror failures), enabling better monitoring and investigation of corpora download reliability for filebeat consumption.
Key changes:
- Removed
mirror_failuresparameter from output formatting functions, making mirror failure information always visible when present - Repurposed
--mirror-failuresCLI flag from controlling output visibility to filtering transfers - Added defensive check for stats to prevent empty arrays in output
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| esrally/storage/_transfer.py | Removed mirror_failures parameter from pretty() and info() methods; mirror failures now shown automatically when present |
| esrally/storage/_cli.py | Removed mirror_failures parameter from ls(), transfer_to_dict(), and transfer_to_filebeat() functions; added defensive check for empty stats |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to store connectivity statistics we would like to create a file to be consumed by
filebeatwith all the informations required for investigating corpora download issue and monitor its reliability and speed. With this purpose theesrally-storage lssub-command now always shows mirror failures, without requiring--mirror-failuresflag which is intended to ignore those transfers that have any mirror failure (for example in order to populate a mirror bucket usingesrally-storage putsub-command).