feat: add maintenance windows option to all monitor types #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vigneshshanmugam
left a comment
vigneshshanmugam
left a comment
There was a problem hiding this comment.
Do we need to provide via CLI and Synthetics config?
Contributor
Author
|
@vigneshshanmugam This already supports mw through the synthetics config file, I'm adding the cli support now. Thank you! |
mcapell
previously approved these changes
Nov 21, 2025
| }); | ||
| }); | ||
|
|
||
| it('supports maintenance-windows in config', async () => { |
2 tasks
vigneshshanmugam
previously approved these changes
Nov 21, 2025
Member
vigneshshanmugam
left a comment
vigneshshanmugam
left a comment
There was a problem hiding this comment.
Added few suggestions, the code LGTM
emilioalvap
added a commit
to elastic/docs-content
that referenced
this pull request
Nov 24, 2025
<!-- Thank you for contributing to the Elastic Docs! 🎉 Use this template to help us efficiently review your contribution. --> ## Summary <!-- Describe what your PR changes or improves. If your PR fixes an issue, link it here. If your PR does not fix an issue, describe the reason you are making the change. --> Add maintenance windows options to synthetics docs. Relates to elastic/synthetics#1103. ## Generative AI disclosure <!-- To help us ensure compliance with the Elastic open source and documentation guidelines, please answer the following: --> 1. Did you use a generative AI (GenAI) tool to assist in creating this contribution? - [ ] Yes - [x] No <!-- 2. If you answered "Yes" to the previous question, please specify the tool(s) and model(s) used (e.g., Google Gemini, OpenAI ChatGPT-4, etc.). Tool(s) and model(s) used: --> --------- Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
emilioalvap
dismissed stale reviews from vigneshshanmugam and mcapell
via
5fa30bb
emilioalvap
commented
Nov 24, 2025
mcapell
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds maintenance windows support for all monitor types:
Related issues: