Skip to content

Comments

ST7735 TFT Display Support for daisy seed#680

Open
noisehoho wants to merge 4 commits intoelectro-smith:masterfrom
noisehoho:master
Open

ST7735 TFT Display Support for daisy seed#680
noisehoho wants to merge 4 commits intoelectro-smith:masterfrom
noisehoho:master

Conversation

@noisehoho
Copy link

This adds support for ST7735 RGB TFT displays

@dromer
Copy link

dromer commented Dec 10, 2025

Neat! But shouldn't the header be in src/dev/ ?

Its a bit odd to see Oopsy documentation here though. Shouldn't that go to the oopsy repo?

Also if it's a drop-in replacement for the SSD130x then it should work ootb with Heavy as well?

@stephenhensley
Copy link
Collaborator

stephenhensley commented Feb 19, 2026

Seems cool, but definitely a few things to make this merge-able.

Setting up "themes" with fore/background colors to maintain compatibility with the existing single color display drivers is nice.

As @dromer mentioned, the device driver itself should exist within the library code (src/dev is a good path).

The json for oopsy probably won't work as-is.. It would need to be added to the component_defs.json, and IIRC we don't have custom json/component support for displays in oopsy -- the implementation is hard-coded for the few devices it was added for (patch, field, bluemchen).
If what you have, or something similar, is functional when added to oopsy, feel free to make a PR against the dev branch there with the working changes.

The README for the example should also be reduced to documenting the example itself.
It would be nice to see some evidence of this working on some hardware since this otherwise looks like output from an LLM, making it more difficult to tell if it has been tested or not.

Also, some notes on the example:

  1. The example draws a static image as frequently as possible. So the actual drawing could probably move before the while loop unless you want to add some movement that justifies keeping inside the loop.
  2. The Makefile for the example isn't valid, or consistent with other libDaisy examples.

Let me know if you have questions, and thanks for contributing! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants