Skip to content

Fix react-native-gesture-handler#198

Open
LcTwisk wants to merge 1 commit intoelectrode-io:masterfrom
LcTwisk:fix-react-native-gesture-handler
Open

Fix react-native-gesture-handler#198
LcTwisk wants to merge 1 commit intoelectrode-io:masterfrom
LcTwisk:fix-react-native-gesture-handler

Conversation

@LcTwisk
Copy link
Copy Markdown
Contributor

@LcTwisk LcTwisk commented Dec 8, 2020

This one is basically the same as #115 but I have added it to v0.34.0+ because of the replaceInFile usage.

@LcTwisk LcTwisk force-pushed the fix-react-native-gesture-handler branch from cd578f2 to d3ea62f Compare December 8, 2020 18:46
@LcTwisk LcTwisk force-pushed the fix-react-native-gesture-handler branch from d3ea62f to 800eec8 Compare December 8, 2020 22:41

## For Android

Create a custom delegate(`ReactNativeGestureDelegate.java`) by extending `ElectrodeReactFragmentActivityDelegate.java` and override the following method.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ElectrodeReactFragmentActivityDelegate is deprecated. Please use ElectrodeNavigationActivityDelegate instead.

@deepueg
Copy link
Copy Markdown
Contributor

deepueg commented Dec 15, 2020

Can you also add a manifest entry pls ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants