Skip to content

fix: don't spawn shell: true on Windows anymore#52

Merged
jkleinsc merged 1 commit intomainfrom
fix-local-yarn-win
Jan 12, 2026
Merged

fix: don't spawn shell: true on Windows anymore#52
jkleinsc merged 1 commit intomainfrom
fix-local-yarn-win

Conversation

@codebytere
Copy link
Member

Refs #51

Fixes:

npm error HEAD is now at 4430e4a build(deps): bump actions/setup-node from 6.0.0 to 6.1.0 (#786)
npm error 'C:\Program' is not recognized as an internal or external command,
npm error operable program or batch file.
npm error Failed to install build-tools:  Error: Command "yarn install" failed with exit code 1
npm error     at throwForBadSpawn (file:///C:/Users/ContainerAdministrator/AppData/Roaming/npm/node_modules/@electron/build-tools/preinstall.js:13:11)
npm error     at install (file:///C:/Users/ContainerAdministrator/AppData/Roaming/npm/node_modules/@electron/build-tools/preinstall.js:60:5)
npm error     at file:///C:/Users/ContainerAdministrator/AppData/Roaming/npm/node_modules/@electron/build-tools/preinstall.js:81:1
npm error     at ModuleJob.run (node:internal/modules/esm/module_job:343:25)
npm error     at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:665:26)
npm error     at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:117:5)
npm error A complete log of this run can be found in: C:\Users\ContainerAdministrator\AppData\Local\npm-cache\_logs\2026-01-12T14_20_07_275Z-debug-0.log

as seen in https://github.com/electron/electron/actions/runs/20922534306/job/60111797235?pr=49362

@codebytere codebytere requested a review from a team as a code owner January 12, 2026 14:26
@codebytere codebytere changed the title fix: don't spawn shell: true on windows anymore fix: don't spawn shell: true on Windows anymore Jan 12, 2026
@jkleinsc jkleinsc merged commit e01de47 into main Jan 12, 2026
7 checks passed
@jkleinsc jkleinsc deleted the fix-local-yarn-win branch January 12, 2026 14:34
@electron-npm-package-publisher

🎉 This PR is included in version 2.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants