fix: e sync, compare paths with no case #589
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
Member
MarshallOfSound
left a comment
MarshallOfSound
left a comment
There was a problem hiding this comment.
I don't think lower casing the path is right here as some filesystems are case sensitive, we probably just want to ensure path paths are fully normalized / resolved.
Author
|
@MarshallOfSound , Is it fine to make such a patch only for the Windows platform, like that? |
MarshallOfSound
approved these changes
May 25, 2024
Member
MarshallOfSound
left a comment
MarshallOfSound
left a comment
There was a problem hiding this comment.
Updated this to use a generic approach to filesystem path sensitivity
Member
|
@andrewsml This PR is now ready to go but we require PRs to this (and some other Electron repos) to come with signed commits. Please set that up, or we can extract this PR into a new one with signed commits from a different auther |
Member
|
Closing as abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #588
Path returned by
git rev-parse --show-toplevelafter normalizing contain C: drive in upper case, so further string comparison fails