Skip to content

feat: add integrity digest plugin#4159

Open
nmggithub wants to merge 4 commits intoelectron:nextfrom
nmggithub:integrity-digest-plugin
Open

feat: add integrity digest plugin#4159
nmggithub wants to merge 4 commits intoelectron:nextfrom
nmggithub:integrity-digest-plugin

Conversation

@nmggithub
Copy link

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This follows up electron/asar#380, which implements a management API for electron/electron#48587.

Some additional things we might want to do:

  1. Add the plugin to https://github.com/electron/forge/blob/next/packages/api/core/src/api/init-scripts/init-npm.ts
  2. Add the plugin to the default templates.
  3. Anything else beyond the plugin simply existing.

@nmggithub nmggithub requested a review from a team as a code owner March 5, 2026 23:14
@nmggithub nmggithub force-pushed the integrity-digest-plugin branch from c369190 to a456367 Compare March 5, 2026 23:23
@socket-security
Copy link

socket-security bot commented Mar 5, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​electron/​asar@​4.1.010010010083100

View full report

@erickzhao erickzhao added the next label Mar 5, 2026
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin code seems pretty straightforward but we need to update some config stuff on the library side (^:

nmggithub and others added 3 commits March 13, 2026 02:37
Co-authored-by: Erick Zhao <erick@hotmail.ca>
…plugin

Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
@nmggithub nmggithub requested a review from erickzhao March 13, 2026 06:38
@nmggithub
Copy link
Author

Thanks for the comments @erickzhao !

What are your thoughts on these three line items from my original post?

  1. Add the plugin to https://github.com/electron/forge/blob/next/packages/api/core/src/api/init-scripts/init-npm.ts
  2. Add the plugin to the default templates.
  3. Anything else beyond the plugin simply existing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants