Skip to content

fix(plugin-vite): improve child logging #4165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
erickzhao wants to merge 1 commit into
base: next
Choose a base branch
from
+13 −5
Draft

fix(plugin-vite): improve child logging #4165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions packages/plugin/vite/src/VitePlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,13 @@ function spawnViteBuild(
FORGE_VITE_INDEX: String(index),
FORGE_VITE_CONFIG: JSON.stringify(pluginConfig),
},
stdio: ['ignore', 'ignore', 'pipe'],
stdio: ['ignore', 'pipe', 'pipe'],
});

let stdout = '';
child.stdout.setEncoding('utf8');
child.stdout.on('data', (chunk) => {
stdout += chunk;
});

let stderr = '';
Expand All @@ -52,15 +58,17 @@ function spawnViteBuild(
});

child.on('error', reject);
child.on('close', (code) => {
child.on('close', (code, signal) => {
if (code === 0) {
resolve();
} else {
const output = [stdout, stderr].filter(Boolean).join('\n');
const reason = signal
? `killed by signal ${signal}`
: `exited with code ${code}`;
reject(
new Error(
`Vite build subprocess exited with code ${code}${
stderr ? `:\n${stderr}` : ''
}`,
`Vite build subprocess ${reason}${output ? `:\n${output}` : ''}`,
),
);
}
Expand Down
Loading