consensus: use ceil(2N/3) quorum in committed seal verification#48
Merged
chrischarlesharrison merged 1 commit intomasterfrom Feb 23, 2026
Merged
consensus: use ceil(2N/3) quorum in committed seal verification#48chrischarlesharrison merged 1 commit intomasterfrom
chrischarlesharrison merged 1 commit intomasterfrom
Conversation
The existing check used 2*F()+1 which assumes the classical BFT relation N=3F+1, but F() here is derived via ceil(N/3)-1 rather than the standard floor((N-1)/3). This non-standard F() definition means 2F+1 diverges from the intended ceil(2N/3) quorum for validator set sizes that aren't exactly 3F+1. Replace with an explicit ceil(2N/3) to match the core consensus quorum and avoid any ambiguity from the atypical F() derivation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing check used 2*F()+1 which assumes the classical BFT relation N=3F+1, but F() here is derived via ceil(N/3)-1 rather than the standard floor((N-1)/3). This non-standard F() definition means 2F+1 diverges from the intended ceil(2N/3) quorum for validator set sizes that aren't exactly 3F+1. Replace with an explicit ceil(2N/3) to match the core consensus quorum and avoid any ambiguity from the atypical F() derivation.