Skip to content

uncomment required seals definition #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrischarlesharrison merged 1 commit into from
Mar 17, 2026
Merged

uncomment required seals definition #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion consensus/istanbul/engine/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,8 @@ func (e *Engine) verifyCommittedSeals(chain consensus.ChainHeaderReader, header
return istanbulcommon.ErrInvalidCommittedSeals
}

// IBFT/QBFT finalization requires at least 2F+1 valid committed seals requiredSeals := int(math.Ceil(float64(2*validators.Size()) / 3))
// IBFT/QBFT finalization requires at least 2F+1 valid committed seals
requiredSeals := int(math.Ceil(float64(2*validators.Size()) / 3))
if validSeal < requiredSeals {
return istanbulcommon.ErrInvalidCommittedSeals
}
Expand Down
Loading