Add tests for yaml object format #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, that also explains one of the bugs I was having problems fixing. Thanks. |
|
No problem! Yeah, this doesn't actually change any functionality so it won't fix a bug.. but I would be supportive of more strict yaml loading even if it breaks backwards compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current format of candidate bios is strange in that it uses an array to store individual discrete fields. This causes issues when parsing this yaml using other libraries, such as golang's gopkg.in/yaml.v3.
This adds tests for both formats, so that elekto is able to maintain backwards compatibility, as well as ensure the proper yaml syntax can be used going forward.