Skip to content

Conversation

@hughns
Copy link
Member

@hughns hughns commented Dec 15, 2025

From https://spec.matrix.org/v1.16/client-server-api/#mchange_password-capability. This isn't listed as a requirement for OAuth 2.0 aware MSC3824, but does make the UX more sensible.

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

From https://spec.matrix.org/v1.16/client-server-api/#mchange_password-capability. This isn't listed as a requirement for OAuth 2.0 aware MSC3824, but does make the UX more sensible.
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 16.96%. Comparing base (ede2db6) to head (1657e06).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
Riot/Modules/Settings/SettingsViewController.m 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7990      +/-   ##
===========================================
- Coverage    16.96%   16.96%   -0.01%     
===========================================
  Files         1766     1766              
  Lines       122112   122112              
  Branches     49184    49183       -1     
===========================================
- Hits         20719    20715       -4     
- Misses      100717   100721       +4     
  Partials       676      676              
Flag Coverage Δ
unittests 8.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks. Just needs a changelog 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants