Skip to content

Conversation

@hughns
Copy link
Member

@hughns hughns commented Dec 15, 2025

Depends on matrix-org/matrix-ios-sdk#1917.

Fixes #7925

n.b. this still doesn't implement the SSO redirect parameter as described for MSC3824:

  • append action=login and action=register parameters to the SSO redirect URLs

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@pixlwave
Copy link
Member

Ah but will need a changelog of course :)

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.97%. Comparing base (ede2db6) to head (4ea0e5f).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
Riot/Modules/Settings/SettingsViewController.m 0.00% 3 Missing ⚠️
...ions/Coordinator/UserSessionsFlowCoordinator.swift 0.00% 3 Missing ⚠️
...curity/ManageSession/ManageSessionViewController.m 0.00% 2 Missing ⚠️
...mmon/Service/MatrixSDK/AuthenticationService.swift 33.33% 1 Missing and 1 partial ⚠️
.../Coordinator/UserSessionsOverviewCoordinator.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7991   +/-   ##
========================================
  Coverage    16.96%   16.97%           
========================================
  Files         1766     1766           
  Lines       122112   122110    -2     
  Branches     49184    49183    -1     
========================================
+ Hits         20719    20726    +7     
+ Misses      100717   100710    -7     
+ Partials       676      674    -2     
Flag Coverage Δ
unittests 8.82% <8.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hughns and others added 5 commits January 6, 2026 13:07
Depends on matrix-ios-sdk branch.

n.b. this still doesn't implement the SSO redirect parameter as described for MSC3824:

> - append action=login and action=register parameters to the SSO redirect URLs
@pixlwave pixlwave force-pushed the hughns/oauth-stable branch from 591d67c to 4ea0e5f Compare January 6, 2026 13:07
@pixlwave pixlwave marked this pull request as ready for review January 6, 2026 13:08
@pixlwave
Copy link
Member

pixlwave commented Jan 6, 2026

I've also included a small fix for the sunset banners in here too (I guess something else changed in the configuration between now and when we tested these against beta.matrix.org).

And there's a fix for the UI tests in #7994.

@pixlwave pixlwave merged commit 9e8f45c into develop Jan 6, 2026
6 of 8 checks passed
@pixlwave pixlwave deleted the hughns/oauth-stable branch January 6, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detection of delegated OIDC once logged in is outdated.

3 participants