Conversation
zeebok
reviewed
Jun 1, 2025
| } | ||
|
|
||
| private async string save_art_file (Gdk.Texture texture, File file) throws Error requires (texture != null) { | ||
| DirUtils.create_with_parents (get_art_cache_dir (), 0755); |
Contributor
There was a problem hiding this comment.
Is this the right permission to use? I would think 644 since it doesn't need to be executable
Member
Author
There was a problem hiding this comment.
It's because this is for the parent folder, not the file. So for folders 7 is access, not execute
zeebok
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somewhat related to #802, but doesn't actually solve that issue. We need to cache covers on disk anyways to send them to MPRIS