Skip to content

ludwig ray datasource checkin#4

Open
SumanthDatta-Kony wants to merge 5 commits intoelevo-ai:masterfrom
SumanthDatta-Kony:latest_ray_ds
Open

ludwig ray datasource checkin#4
SumanthDatta-Kony wants to merge 5 commits intoelevo-ai:masterfrom
SumanthDatta-Kony:latest_ray_ds

Conversation

@SumanthDatta-Kony
Copy link
Copy Markdown

Code Pull Requests

Please provide the following:

  • Added an extra datasource which is ray datasource, ray datasource can now be passed to read from foresight.



# Load model from checkpoint
# Load model from checkpoint
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the extra indentation

Comment on lines +534 to +535
logger.info("###### checkpoint: {}".format(trainer_results.checkpoint)) # ***FIXME
print("###### checkpoint: {}".format(trainer_results.checkpoint)) # ***FIXME
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete these extra prints.

Comment on lines +522 to +531
if "validation_field" in trainer_results.metrics:
self._validation_field = trainer_results.metrics["validation_field"]
else:
self._validation_field = None

if "validation_metric" in trainer_results.metrics:
self._validation_metric = trainer_results.metrics["validation_metric"]
else:
self._validation_metric = None

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this change done?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a Key error exception while testing one our solutions

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which solution?
what is the exact error that it is complaining about? can you paste the stack trace.
can you fix it by changing the ML job file parameters (for example. see git issue 2458)

Copy link
Copy Markdown
Author

@SumanthDatta-Kony SumanthDatta-Kony Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change the parameters in the ml job file, reverted the code

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 14, 2023

Unit Test Results

       6 files  ±0         6 suites  ±0   45m 54s ⏱️ - 28m 57s
2 792 tests ±0  2 769 ✔️  - 2  12 💤 ±0  11 +2 
8 376 runs  ±0  8 309 ✔️  - 4  36 💤 ±0  31 +4 

For more details on these failures, see this check.

Results for commit 67db94f. ± Comparison against base commit 4491d65.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants