Fix Nextcloud App Critical Issues & Add Configuration#2
Open
Fix Nextcloud App Critical Issues & Add Configuration#2
Conversation
Add missing API route and controller method for admin settings: - Add /api/admin/settings POST route in routes.php - Implement saveAdmin() method in SettingsController - Add validation for empty API key - Store admin key using setAppValue() This fixes the bug where admins couldn't save API keys through the UI because the endpoint didn't exist. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Create comprehensive personal settings interface: - New user.php template with API key form - UserSettings class implementing ISettings interface - user.js for form handling and API interaction - user.css for consistent styling - Register personal settings in info.xml Features: - Save personal API key (overrides admin key) - Clear personal key (fall back to admin key) - Visual feedback for success/error states - Confirmation dialog before clearing key 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Input Validation & Rate Limiting: - Add content length validation (max 100KB) - Implement rate limiting (10 requests/minute per user) - Use distributed cache for rate limit tracking - Return proper HTTP status codes (429, 413) Configurable Advanced Settings: - Model selection (custom input with suggestions) - Max tokens (1-100,000, default 4096) - API timeout (10-1800s = 30min, default 30s) - All settings configurable via admin UI Implementation: - ChatController: Add rate limiting and validation - ClaudeService: Configurable model, tokens, timeout - SettingsController: Save advanced settings - Admin UI: Form fields for all settings - Enhanced CSS: Better form styling This prevents API abuse, quota exhaustion, and provides flexibility for different use cases. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update app version to reflect critical bug fixes and new features added in this release. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Mark completed items: - User settings UI with personal API key override - Input validation and rate limiting - Configurable settings (model, tokens, timeout) Move "Multiple model selection" from Phase 2 to completed in Phase 1 as it's now implemented with custom model input. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add documentation for new features: - Advanced settings configuration (model, tokens, timeout) - User settings location (Personal settings) - Rate limiting and input validation features Update README with security and configuration features. Update installation guide with step-by-step advanced settings. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Frontend (fileactions.js): - Check file size before processing using Nextcloud metadata - Show warning for files >5MB with actual file size - Inform users about potential failures and admin options - No need to download large files just to reject them Backend (ChatController): - Increase max content length from 100KB to 5MB - Update error messages to show MB instead of KB - Maintain protection against excessively large requests This provides better UX by: - Warning users upfront about large files - Not wasting bandwidth downloading files that will be rejected - Suggesting action (contact admin to increase limit) - Still allowing files up to 5MB by default 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Nextcloud App Critical Issues & Add Configuration
This PR addresses critical bugs and adds essential configuration features for the Nextcloud app.
🐛 Bug Fixes
✨ New Features
Advanced Configuration Options:
Security & Stability:
📚 Documentation
🧪 Test Plan
📦 Version
Bumps version from 0.1.0 → 0.1.1