fix: support Nushell for PATH detection #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Nushell (`nu`) support to `path_env_at_directory/2`. Nushell differs from POSIX shells in two ways: - The `&&` operator is not supported (requires `;` or `and`) - PATH is stored as a list in `$env.PATH`, not a colon-separated string Currently, Expert crashes immediately when `SHELL` is set to Nushell: ``` Error: nu::parser::shell_andand x The '&&' operator is not supported in Nushell ,-[source:1:39] 1 | cd /path/to/project && printf "EXPERT_PATH:%s:EXPERT_PATH" "$PATH" : ^| : `-- instead of '&&', use ';' or 'and' ``` ## Changes - Add `"nu"` case in `path_env_at_directory/2` that uses `;` for command chaining and `$env.PATH | str join ":"` to convert the PATH list to a colon-separated string.
Member
|
Looks good, just fix up the formatter errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Nushell (
nu) support topath_env_at_directory/2inport.ex.Specifically: Adds a
"nu"case inpath_env_at_directory/2that uses;for command chaining and$env.PATH | str join ":"to convert the PATH list to a colon-separated string.Nushell differs from POSIX shells in two ways:
&&operator is not supported (requires;orand)$env.PATH, not a colon-separated stringCurrently, Expert crashes immediately when
SHELLis set to Nushell: