Skip to content

refactor: improve initialization error messages #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doorgan merged 3 commits into from
Dec 22, 2025
Merged

refactor: improve initialization error messages #276

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab6e8e2
refactor: improve initialization error messages
badosu Dec 22, 2025
4e87056
small cleanup
badosu Dec 22, 2025
d1acd49
line too long
badosu Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions apps/expert/lib/expert.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ defmodule Expert do
}
end

defp initialization_error_message({:shutdown, {:failed_to_start_child, child, {reason, _}}}) do
defp initialization_error_message({:shutdown, {:failed_to_start_child, child, reason}}) do
case child do
{Project.Node, node_name} ->
node_initialization_message(node_name, reason)
Expand All @@ -319,12 +319,15 @@ defmodule Expert do

defp node_initialization_message(name, reason) do
case reason do
# NOTE:
# ** (Mix.Error) httpc request failed with: ... Could not install Hex because Mix could not download metadata ...
{:shutdown, {:error, :normal, message}} ->
"Engine #{name} shutdown with error:\n\n#{message}"
# NOTE: ~c"could not compile dependency :elixir_sense..."
{:error, :normal, message} ->
"Engine #{name} initialization failed with error:\n\n#{message}"

{:shutdown, {:node_exit, node_exit}} ->
# NOTE: ** (Mix.Error) httpc request failed with: ...Could not install Hex because Mix could not download...
{{:shutdown, {:error, :normal, message}}, _} ->
"Engine #{name} shut down with error:\n\n#{message}"

{{:shutdown, {:node_exit, node_exit}}, _} ->
"Engine #{name} exit with status #{node_exit.status}, last message:\n\n#{node_exit.last_message}"

reason ->
Expand Down