fix: device in window_scatter_function now uses from_nx #1640
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I gotta validate this in a multidevice environment, so lets hold off on merging for now |
polvalente
reviewed
Oct 27, 2025
Comment on lines
164
to
166
| ```elixir | ||
| Nx.reshape(tensor, {1, 4}, names: [:batches, :values]) | ||
| Nx.reshape(tensor, {1, 6}, names: [:batches, :values]) | ||
| ``` |
There was a problem hiding this comment.
I think this is a stray change. Can you open a separate PR with this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #679
device used to default to the cpu. Now it imports from nx