Create Protobuf.Presence module #403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on-top of #398.
Adds a unified presence tracking module. Makes the different encoders use it when deciding whether to skip a field or not.
Adds a public API for checking field presence on
Protobuf.Presence.field_presence/2. This is similar to the feature present on the official protobuf libraries, but with a different API.In Ruby, for example, fields that have explicit presence tracking generate a
has_{field_name}?method:If another field, say
bar, doesn't have explicit presence tracking (e.g.: it is a non-optional, non-one_of proto3), it simply doesn't generate thehas_bar?method, so you can't "presence-check" these fields.My proposed API is a bit different, and allows presence-checking
:bar, but sometimes givinga
:maybeas a response:Motivation
I think it makes sense to centralize presence checking for a few reasons:
Protobuf.Text.