Skip to content

Disallow srcdoc #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disallow srcdoc #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Elm/Kernel/VirtualDom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ var _VirtualDom_attributeNS = F3(function(namespace, key, value)


var _VirtualDom_RE_script = /^script$/i;
var _VirtualDom_RE_on_formAction = /^(on|formAction$)/i;
var _VirtualDom_RE_unsafeAttribute = /^(on|formAction|srcdoc$)/i;
var _VirtualDom_RE_js = /^\s*j\s*a\s*v\s*a\s*s\s*c\s*r\s*i\s*p\s*t\s*:/i;
var _VirtualDom_RE_js_html = /^\s*(j\s*a\s*v\s*a\s*s\s*c\s*r\s*i\s*p\s*t\s*:|d\s*a\s*t\s*a\s*:\s*t\s*e\s*x\s*t\s*\/\s*h\s*t\s*m\s*l\s*(,|;))/i;

Expand All @@ -296,14 +296,14 @@ function _VirtualDom_noScript(tag)
return _VirtualDom_RE_script.test(tag) ? 'p' : tag;
}

function _VirtualDom_noOnOrFormAction(key)
function _VirtualDom_noUnsafeAttribute(key)
{
return _VirtualDom_RE_on_formAction.test(key) ? 'data-' + key : key;
return _VirtualDom_RE_unsafeAttribute.test(key) ? 'data-' + key : key;
}

function _VirtualDom_noInnerHtmlOrFormAction(key)
function _VirtualDom_noUnsafeProperty(key)
{
return key == 'innerHTML' || key == 'outerHTML' || key == 'formAction' ? 'data-' + key : key;
return key == 'innerHTML' || key == 'outerHTML' || key == 'formAction' || key == 'srcdoc' ? 'data-' + key : key;
}

function _VirtualDom_noJavaScriptUri(value)
Expand Down
6 changes: 3 additions & 3 deletions src/VirtualDom.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ would be in JavaScript, not `for` as it would appear in HTML.
property : String -> Json.Value -> Attribute msg
property key value =
Elm.Kernel.VirtualDom.property
(Elm.Kernel.VirtualDom.noInnerHtmlOrFormAction key)
(Elm.Kernel.VirtualDom.noUnsafeProperty key)
(Elm.Kernel.VirtualDom.noJavaScriptOrHtmlJson value)


Expand All @@ -181,7 +181,7 @@ be in HTML, not `htmlFor` as it would appear in JS.
attribute : String -> String -> Attribute msg
attribute key value =
Elm.Kernel.VirtualDom.attribute
(Elm.Kernel.VirtualDom.noOnOrFormAction key)
(Elm.Kernel.VirtualDom.noUnsafeAttribute key)
(Elm.Kernel.VirtualDom.noJavaScriptOrHtmlUri value)


Expand All @@ -199,7 +199,7 @@ attributeNS : String -> String -> String -> Attribute msg
attributeNS namespace key value =
Elm.Kernel.VirtualDom.attributeNS
namespace
(Elm.Kernel.VirtualDom.noOnOrFormAction key)
(Elm.Kernel.VirtualDom.noUnsafeAttribute key)
(Elm.Kernel.VirtualDom.noJavaScriptOrHtmlUri value)


Expand Down