Skip to content

Conversation

@felixbuenemann
Copy link
Contributor

Patches the folllowing deprecation warnings:

  • deprecate-import-onerror-from-ember
  • importing-inject-from-ember-service
  • deprecate-import-view-utils-from-ember

@felixbuenemann
Copy link
Contributor Author

I don't know how to write a version of the code that supports both import { service } from '@ember/service' and import { inject as service } from '@ember/service' at the same time. Maybe one of the maintainers has an answer.

@felixbuenemann
Copy link
Contributor Author

One option would be to only keep the deprecate-import-view-utils-from-ember deprecation fix, which fixes the deprecation message in the browser that can't be silenced by app/deprecation-workflow.js and rely on that for the other two deprecations for now.

@felixbuenemann
Copy link
Contributor Author

felixbuenemann commented Nov 17, 2025

I added the import * as serviceModule from '@ember/service' workaround to support older Ember.js versions, as suggested by @SergeAstapov, but now the packaging tests fail with:

Using import * as serviceModule from '@ember/service' is not supported.

I'm not sure what to do about that other than dropping support for older Ember.js versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants