Fix: parcentage value calculation is fixed so the value is rounded.#98
Open
mtskf wants to merge 2 commits intoemn178:masterfrom
Open
Fix: parcentage value calculation is fixed so the value is rounded.#98mtskf wants to merge 2 commits intoemn178:masterfrom
mtskf wants to merge 2 commits intoemn178:masterfrom
Conversation
added 2 commits
June 20, 2019 12:11
…rather than floored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The percentage value was calculated by .toFixed method which just cut the decimal values like Math.floor. I updated the logic for the percentage values so it's properly rounded at the specified decimal position by the precision option.
ie:
When the value is 56.5556 and the precision is 1:
original version: 56.5%
updated version: 56.6%
I'd appreciate if you could merge this fix.
Cheers:)