Clamp image position to avoid showing empty areas#4
Open
Tsukina-7mochi wants to merge 1 commit intoenmarimo:mainfrom
Open
Clamp image position to avoid showing empty areas#4Tsukina-7mochi wants to merge 1 commit intoenmarimo:mainfrom
Tsukina-7mochi wants to merge 1 commit intoenmarimo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent images from moving off-screen when users drag and zoom them, I have implemented clamping for
image_pos.notes:
onmousemovewas avoided because theGraphicsContextis hard to be obtained.image_originbecause the displacement of the grab position seems unsettling.sample file
reference_viewer-v0.5.3.zip
preview
reference-viewer.mp4