Skip to content

Remove support of relative node paths #11729#11730

Merged
rymsha merged 2 commits intomasterfrom
11729-remove-support-of-relative-node-paths
Feb 9, 2026
Merged

Remove support of relative node paths #11729#11730
rymsha merged 2 commits intomasterfrom
11729-remove-support-of-relative-node-paths

Conversation

@rymsha
Copy link
Contributor

@rymsha rymsha commented Feb 9, 2026

No description provided.

@rymsha rymsha linked an issue Feb 9, 2026 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes support for relative NodePath values and updates query/path construction to align with the new absolute-path-only behavior.

Changes:

  • Tightens NodePath API to reject empty paths and normalize inputs to absolute paths.
  • Simplifies DiffQueryFactory by removing configurable child storage type and rebuilding path/exclude filters.
  • Updates several call sites and tests to use NodePath.create() and absolute path semantics.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
modules/core/core-repo/src/test/java/com/enonic/xp/repo/impl/storage/NodeStorageServiceImplTest.java Updates test fixtures to use non-root/absolute NodePath construction and streamlined Mockito setup.
modules/core/core-repo/src/main/java/com/enonic/xp/repo/impl/elasticsearch/query/translator/factory/DiffQueryFactory.java Removes childStorageType plumbing and rewrites branch/path filtering queries.
modules/core/core-repo/src/main/java/com/enonic/xp/repo/impl/elasticsearch/query/translator/NodeVersionDiffQueryTranslator.java Adapts to DiffQueryFactory builder API change (no child storage type).
modules/core/core-app/src/main/java/com/enonic/xp/core/impl/app/DynamicSchemaServiceImpl.java Switches to NodePath.create() for schema/component paths.
modules/core/core-api/src/test/java/com/enonic/xp/node/NodePathTest.java Updates unit tests to reflect absolute-only and non-empty NodePath behavior.
modules/core/core-api/src/main/java/com/enonic/xp/node/NodePath.java Enforces non-empty input, normalizes path string formation, and removes relative/empty semantics.
modules/core/core-api/src/main/java/com/enonic/xp/node/CreateNodeParams.java Removes absolute-path validation (likely obsolete with new NodePath behavior) and reformats builder chaining.

@rymsha rymsha force-pushed the 11729-remove-support-of-relative-node-paths branch from 8cf2665 to d47df4f Compare February 9, 2026 10:15
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.71%. Comparing base (140fc8b) to head (b819c35).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11730      +/-   ##
============================================
- Coverage     86.72%   86.71%   -0.01%     
+ Complexity    19727    19704      -23     
============================================
  Files          2540     2540              
  Lines         66782    66737      -45     
  Branches       5358     5343      -15     
============================================
- Hits          57914    57874      -40     
+ Misses         6274     6273       -1     
+ Partials       2594     2590       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rymsha rymsha merged commit 3622c3d into master Feb 9, 2026
11 checks passed
@rymsha rymsha deleted the 11729-remove-support-of-relative-node-paths branch February 9, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support of relative node paths

3 participants