Remove support of relative node paths #11729#11730
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes support for relative NodePath values and updates query/path construction to align with the new absolute-path-only behavior.
Changes:
- Tightens
NodePathAPI to reject empty paths and normalize inputs to absolute paths. - Simplifies
DiffQueryFactoryby removing configurable child storage type and rebuilding path/exclude filters. - Updates several call sites and tests to use
NodePath.create()and absolute path semantics.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/core/core-repo/src/test/java/com/enonic/xp/repo/impl/storage/NodeStorageServiceImplTest.java | Updates test fixtures to use non-root/absolute NodePath construction and streamlined Mockito setup. |
| modules/core/core-repo/src/main/java/com/enonic/xp/repo/impl/elasticsearch/query/translator/factory/DiffQueryFactory.java | Removes childStorageType plumbing and rewrites branch/path filtering queries. |
| modules/core/core-repo/src/main/java/com/enonic/xp/repo/impl/elasticsearch/query/translator/NodeVersionDiffQueryTranslator.java | Adapts to DiffQueryFactory builder API change (no child storage type). |
| modules/core/core-app/src/main/java/com/enonic/xp/core/impl/app/DynamicSchemaServiceImpl.java | Switches to NodePath.create() for schema/component paths. |
| modules/core/core-api/src/test/java/com/enonic/xp/node/NodePathTest.java | Updates unit tests to reflect absolute-only and non-empty NodePath behavior. |
| modules/core/core-api/src/main/java/com/enonic/xp/node/NodePath.java | Enforces non-empty input, normalizes path string formation, and removes relative/empty semantics. |
| modules/core/core-api/src/main/java/com/enonic/xp/node/CreateNodeParams.java | Removes absolute-path validation (likely obsolete with new NodePath behavior) and reformats builder chaining. |
modules/core/core-app/src/main/java/com/enonic/xp/core/impl/app/DynamicSchemaServiceImpl.java
Outdated
Show resolved
Hide resolved
modules/core/core-app/src/main/java/com/enonic/xp/core/impl/app/DynamicSchemaServiceImpl.java
Outdated
Show resolved
Hide resolved
modules/core/core-app/src/main/java/com/enonic/xp/core/impl/app/DynamicSchemaServiceImpl.java
Outdated
Show resolved
Hide resolved
...in/java/com/enonic/xp/repo/impl/elasticsearch/query/translator/factory/DiffQueryFactory.java
Show resolved
Hide resolved
...in/java/com/enonic/xp/repo/impl/elasticsearch/query/translator/factory/DiffQueryFactory.java
Outdated
Show resolved
Hide resolved
...in/java/com/enonic/xp/repo/impl/elasticsearch/query/translator/factory/DiffQueryFactory.java
Outdated
Show resolved
Hide resolved
8cf2665 to
d47df4f
Compare
anatol-sialitski
approved these changes
Feb 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11730 +/- ##
============================================
- Coverage 86.72% 86.71% -0.01%
+ Complexity 19727 19704 -23
============================================
Files 2540 2540
Lines 66782 66737 -45
Branches 5358 5343 -15
============================================
- Hits 57914 57874 -40
+ Misses 6274 6273 -1
+ Partials 2594 2590 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ashklianko
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.