Periodic upload of open hybrid projects #14167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
the
CI: No changelog needed
4e6
force-pushed
the
wip/db/14127-periodic-upload
branch
from
3a96809 to
d6af21f
Compare
4e6
force-pushed
the
wip/db/14127-periodic-upload
branch
2 times, most recently
from
5cc0f65 to
1c864f2
Compare
4e6
force-pushed
the
wip/db/14127-periodic-upload
branch
from
1c864f2 to
91d314f
Compare
4e6
requested review from
AdRiley,
Frizi,
PabloBuchu,
farmaazon,
indiv0,
kazcw and
vitvakatu
as code owners
farmaazon
reviewed
Nov 21, 2025
| localProjectId: backend.ProjectId, | ||
| parentDirectoryId: backend.DirectoryId, | ||
| baseUrl: URL, | ||
| defaultHeaders: Record<string, string>, |
Contributor
There was a problem hiding this comment.
I have no idea why do we need defaultHeaders if we already have access to HTTPClient (and for example, stopWatchingHybridProject does not need them).
PabloBuchu
approved these changes
Dec 2, 2025
farmaazon
approved these changes
Dec 3, 2025
| if (!response.ok) { | ||
| return await this.throw(response, 'resolveProjectAssetPathBackendError') | ||
| } | ||
| const httpStatusIsDirty = 201 |
Contributor
There was a problem hiding this comment.
Seems like stopping watcher results in created HTTP code? For me, it's a bit unintuitive. I would rather expect some information in the response body.
jdunkerley
pushed a commit
that referenced
this pull request
Dec 5, 2025
- close #14127 PR implements periodic uploads for opened hybrid projects Changelog: - add: implement directory watcher - update: project state management to start and stop directory watcher - update: HttpClient to work in NodeJS environment # Important Notes Followup: - we need some progress indication about the project state (think of Google Docs) i.e. unsaved, saving, saved - each upload creates a new version of the project. We need to update the upload endpoint to have an option to overwrite the latest version instead of always creating a new one. (cherry picked from commit 5a2012d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
PR implements periodic uploads for opened hybrid projects
Changelog:
Important Notes
Followup:
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.