-
Notifications
You must be signed in to change notification settings - Fork 334
Add flags to run project in command line #14310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…erver to be active)
the relative path is also is this is case sensitive? |
Is it something we can handle easily or should be put as improvement? |
| case 'audio': | ||
| case 'video': { | ||
| const blob = await response.blob() | ||
| const url = URL.createObjectURL(blob) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we create the blob outside query, next to a place when we set revoke?
| } | ||
| })() | ||
|
|
||
| function checkExecutables(...segments: readonly string[]): Path | undefined { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic could be tested, with some mock for accessSync
vitvakatu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes break electron app building in Bazel, but I don’t have a problem with that. I have a problem with leftover .env files in app/gui. If they are no longer used — they should be cleaned up. Also duplication of config.ts must be resolved, we can’t have two identical files.
| /** | ||
| * @file This file defines a global environemnt config that can be used throughout the app. | ||
| * It is included directly into index.html and kept as a separate built artifact, so that | ||
| * we can easily replace its contents in a separate build postprocessing step in `BUILD.bazel`. | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same question.
|
thanks for the comments, much appreciated. @vitvakatu unfortunately i think
|
Pull Request Description
Main.ensoimg,video, andaudiorespectively.Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.