Skip to content

Conversation

@AdRiley
Copy link
Member

@AdRiley AdRiley commented Dec 2, 2025

Pull Request Description

Uses the Data_Link_Helper.as_file to allow cloud fiels to be used as email attachments, by materialising them to a temporary local file.

Closes #14363

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@AdRiley AdRiley marked this pull request as ready for review December 2, 2025 14:35
@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 2, 2025
@github-actions github-actions bot added -libs-API-change-Base Marks a PR that changes the public API of Standard.Base labels Dec 2, 2025
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight change to the type check will allow S3 and OneDrive

@AdRiley AdRiley added the CI: Ready to merge This PR is eligible for automatic merge label Dec 3, 2025
@jdunkerley jdunkerley merged commit 6df87ec into develop Dec 3, 2025
65 of 69 checks passed
@jdunkerley jdunkerley deleted the wip/adr/support-cloud-files-in-email-send branch December 3, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-libs-API-change-Base Marks a PR that changes the public API of Standard.Base CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add email support for cloud files

4 participants