Open
Conversation
Replace esteetön with portaaton
| id: `${inputName}_${assistanceAvailability}`, | ||
| })} | ||
| onChange={handleChange} | ||
| disabled={!canBeEdited} |
Collaborator
There was a problem hiding this comment.
One option could be to use disabled={disabled} in here, make canBeEdited be about isAssistanceServicePresent only, and then keep the looping logic under .map as it was before. But matter of personal taste, disabling this input for when user is logged in but isAssistanceServicePresent is false is fine too
Contributor
There was a problem hiding this comment.
I don't have any strong opinion on this, maybe @a-limyr does? Otherwise, I'm happy with whatever you decide here.
testower
requested changes
Feb 26, 2026
Contributor
testower
left a comment
There was a problem hiding this comment.
LGTM, but I would prefer a separate PR for the translations
This reverts commit 9facde9.
Contributor
Author
|
Translations are now removed from this PR and a new one is created for them #1678 |
testower
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes UI components to properly hide or disable interactive elements when a user has read-only access (
disabledprop is set). Previously, some forms, buttons, and selectors were still visible or partially functional for read-only users.Issue
1. Map: Hide action buttons and update cursor on map markers when editing is disabled
disabledis true inStopPlaceMarker.jsautoand guardedonClickhandlers when editing is disabled inQuayMarker.js!disabled && !belongsToNeighbourStopguard into a singlecanInteractvariable inQuayMarker.js2. Assistance: Disable select instead of filtering options for read-only users
AssistanceAvailabilityoptions to only showNONEfor read-only usersdisabledprop on theSelectcomponent — all options remain visible but interaction is blocked3. Alternative names: Hide new alternative name form when user has read-only access
NewAltNameform only when!disabledinAltNamesDialog.js4. Tags: Hide add-tag form and delete button when user has read-only access
AddTagDialogcomponent whendisabledis true inTagsDialog.jsIconButtoninTagItem.jswhendisabledis truedisabledprop throughTagsDialog→TagItemEDIT: Translations are removed from this PR and moved into a separate one #1678
5. i18n: Correct Finnish translations for step-free access terminologyUnit tests
- [x] Verified Finnish translations display correctly in the UIDocumentation
N/A