Convert code badges to rounded rectangles and improve vertical alignment#1679
Open
solita-topip wants to merge 4 commits intoentur:masterfrom
Open
Convert code badges to rounded rectangles and improve vertical alignment#1679solita-topip wants to merge 4 commits intoentur:masterfrom
solita-topip wants to merge 4 commits intoentur:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts public code and private code indicators from circles to rounded rectangles, improves vertical alignment of elements in quay/stop rows, and updates QuayMarkerIcon to display full quay codes on the map with a text-shadow for better legibility against map base layers.
Changes
Issue
In some Abzu installations, stop places and quays have public and/or private codes longer than 3 characters (e.g. AB1234). The current badge design uses a fixed-size circle, which causes longer codes to stretch the circle, making them unreadable.
The same issue affects the quay short name label rendered on the map in QuayMarkerIcon.
Unit tests
Manual and visual verification was performed.
Documentation
N/A