refactor: consolidates all processors with one generic type #1600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathetake
force-pushed
the
genericprocessor
branch
from
296ad2d to
10d37f1
Compare
Member
Author
|
wow cool all tests passing |
mathetake
force-pushed
the
genericprocessor
branch
from
10d37f1 to
f4c2951
Compare
Member
Author
|
Tomorrow i will backfill the tests and then good to go |
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
force-pushed
the
genericprocessor
branch
from
14ccbb3 to
81511ae
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
==========================================
- Coverage 83.97% 83.51% -0.47%
==========================================
Files 141 137 -4
Lines 13021 11934 -1087
==========================================
- Hits 10935 9967 -968
+ Misses 1463 1386 -77
+ Partials 623 581 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dosubot
bot
added
the
size:XXL
mathetake
commented
Dec 2, 2025
Member
Author
There was a problem hiding this comment.
this is where I generalized the ChatCompletionsProcessor with a few type params, almost all the logic is the same
mathetake
commented
Dec 2, 2025
Member
Author
There was a problem hiding this comment.
all new endpoints will only touch this file by declaring one type implementing one small interface and that's it
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Member
Author
|
Cool i came up with some cool trick while eating dinner and now we no longer need to touch internal/extproc AT ALL for adding endpoints!!!!!!! |
mathetake
commented
Dec 3, 2025
| func NewFactory[ReqT any, RespT any, RespChunkT any, EndpointSpecT endpointspec.Spec[ReqT, RespT, RespChunkT]]( | ||
| f metrics.Factory, | ||
| tracer tracing.RequestTracer[ReqT, RespT, RespChunkT], | ||
| _ EndpointSpecT, // This is a type marker to bind EndpointSpecT without specifying ReqT, RespT, RespChunkT explicitly. |
Member
|
/retest |
missBerg
pushed a commit
to missBerg/ai-gateway
that referenced
this pull request
Dec 20, 2025
…xy#1600) **Description** This consolidates all the copy-pasted processors that existed per endpoint we support into one generic processor. This was made possible thanks to the series of refactoring that we landed in the past few weeks primarily for dynamic module work envoyproxy#90. Notably, now in order to add an endpoint, majority of the new code will be in translator (where also have shared generic interface) as well as the type definition. No longer it requires the huge copy paste of processors. **Related Issues/PRs (if applicable)** Resolves envoyproxy#1083 Blocker for envoyproxy#1429 envoyproxy#1584 envoyproxy#1592 envoyproxy#1594 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Co-authored-by: Ignasi Barrera <ignasi@tetrate.io> Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This consolidates all the copy-pasted processors that existed per endpoint we support into one generic processor. This was made possible thanks to the series of refactoring that we landed in the past few weeks primarily for dynamic module work #90.
Notably, now in order to add an endpoint, majority of the new code will be in translator (where also have shared generic interface) as well as the type definition. No longer it requires the huge copy paste of processors.
Related Issues/PRs (if applicable)
Resolves #1083
Blocker for #1429 #1584 #1592 #1594