dynamic_modules: add dynamic modules support for bootstrap extensions #42903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
agrawroh
force-pushed
the
feat-dm-bootstrap
branch
5 times, most recently
from
c0d39e3 to
905480b
Compare
Member
|
Do we actually need this? Because we do rarely need bootstrap extensions? |
agrawroh
force-pushed
the
feat-dm-bootstrap
branch
from
905480b to
2f5b1e1
Compare
Member
Author
Yes, see this issue for context. |
agrawroh
force-pushed
the
feat-dm-bootstrap
branch
from
2f5b1e1 to
c4e9ea0
Compare
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
force-pushed
the
feat-dm-bootstrap
branch
from
c4e9ea0 to
ca29a43
Compare
agrawroh
requested review from
mathetake,
mattklein123 and
wbpcode
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for writing new bootstrap extensions using Dynamic Modules.
Commit Message: dynamic_modules: add dynamic modules support for bootstrap extensions
Additional Description: Adds support for writing new bootstrap extensions using Dynamic Modules.
Risk Level: Low
Testing: Added Unit + Integration Tests
Docs Changes: Added
Release Notes: Added