Remove execution bit from non-executables #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most files have incorrect permission bits regarding execution. Clean
this up by running:
$ find -type f -executable \
> -regex '.*\(pdf\|png\|doc\|txt\|html\|adl\|c\|h\|cpp\|dbd\|db\|substitutions\)$' \
> -exec chmod -x {} \;
Besides those, mcaApp/SISSrc/prom_v0111.mcs and Amptek' BMP files also
had their execution removed.
Windows and VxWorks iocsh scripts should be provided as argument to the IOC binary on those systems. This means scripts themselves do not need to be executable. Moreover, nfsCommands is loaded afterwards in VxWorks scripts, and therefore also does not need to be executable.
These scripts had executable bits set, but none of them was actually executable due to the missing shebang. Add proper shebangs so one can ask the OS to actually run them directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most files have incorrect permission bits regarding execution. Clean this up by running:
find -type f -executable \ -regex '.*\(pdf\|png\|doc\|txt\|html\|adl\|c\|h\|cpp\|dbd\|db\|substitutions\)$' \ -exec chmod -x {} \;Besides those, mcaApp/SISSrc/prom_v0111.mcs and Amptek' BMP files also had their execution removed.
Same thing for Windows and VxWorks iocsh scripts, since they should be provided as argument to the IOC binary on those systems, AFAIK; thus not requiring themselves to be executable.
For Unix scripts, add a shebang so they can be indeed properly executed.